Repository navigation
[No QA] Update docs using Magic Code - #97278
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @zanyrenney |
|
@Pujan92 @zanyrenney One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
| --- | ||
|
|
||
| # Magic Code Login Emails | ||
| # Security Code Login Emails |
There was a problem hiding this comment.
Heading structure violation: This is a second # (H1) heading in the article. Per HELP_AUTHORING_GUIDELINES.md Section 4, an article may have exactly one # heading (the title) plus an optional # FAQ — no other # headings. Demote this to ## Security Code login emails (and make it task-based, e.g. ## How Security Code login emails work).
| # Security Code Login Emails | ||
|
|
||
| Magic Code emails are sent when you log in to Expensify and are critical for account access. These emails may be delayed or blocked due to spam filtering, corporate email policies, or server-level blocks. If you choose to or are automatically directed to sign in via SAML/SSO, you will **not** receive a magic code. | ||
| Security Code emails are sent when you log in to Expensify and are critical for account access. These emails may be delayed or blocked due to spam filtering, corporate email policies, or server-level blocks. If you choose to or are automatically directed to sign in via SAML/SSO, you will **not** receive a security code. |
There was a problem hiding this comment.
Terminology casing inconsistency: This line renames the term to "Security Code" but ends with lowercase "security code" ("you will not receive a security code"). Per HELPSITE_NAMING_CONVENTIONS.md, match capitalization exactly and be consistent. Capitalize as Security Code to match the rest of the diff.
| - Scammers sometimes use urgent language like “Your account will be closed if you don’t respond.” | ||
|
|
||
| **Don’t click suspicious links, and never share your Magic Code in email. Expensify will only generate a magic code for you when you take an action in the app, such as logging in or making a high-risk change.** | ||
| **Don’t click suspicious links, and never share your Security Code in email. Expensify will only generate a security code for you when you take an action in the app, such as logging in or making a high-risk change.** |
There was a problem hiding this comment.
Terminology casing inconsistency: This line uses lowercase "security code" ("Expensify will only generate a security code for you...") while the rest of the diff capitalizes it as Security Code. Per HELPSITE_NAMING_CONVENTIONS.md, match capitalization exactly and be consistent. Use Security Code.
| ## 3. Try Resending | ||
|
|
||
| - **Click "Resend Magic Code"** on the login screen | ||
| - **Click "Resend Security Code"** on the login screen |
There was a problem hiding this comment.
Button naming violation: **Click "Resend Security Code"** wraps the button name in quotation marks. Per HELPSITE_NAMING_CONVENTIONS.md (Button Naming Standards), do not wrap button names in quotation marks — bold only. Use: Click Resend Security Code.
HelpDot Documentation ReviewOverall AssessmentThis PR performs a global terminology migration, renaming Magic Code to Security Code across Expensify Classic Help articles, hidden stubs, and internal AgentZero references. It renames two files (Magic-Code-Access-Troubleshooting.md to Security-Code-Access-Troubleshooting.md and issues-receiving-the-magic-code.md to issues-receiving-the-security-code.md), updates all internal references, and correctly adds two 301 redirects in redirects.csv. The scope is a consistent find-and-replace: metadata (title, description, keywords, internalScope), body copy, FAQ entries, and cross-links were all updated. No new article structure was introduced. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
zanyrenney
left a comment
There was a problem hiding this comment.
all good here, pretty simple ones!
|
@zanyrenney looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/zanyrenney in version: 9.4.47-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.47-7 🚀
Bundle Size Analysis (Sentry): |
cc: @laurenreidexpensify
Updates docs and a few stray comments to use security code or validateCode instead of magic code
Explanation of Change
Fixed Issues
$ #96180
PROPOSAL:
Tests
Verify the help docs linked in #97278 (comment) all use the term security code instead of magic code
Offline tests
N/A
QA Steps
Verify the help docs linked in #97278 (comment) all use the term security code instead of magic code
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari